Project group cypress tests #1170
Draft
+166
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FahadDarw
requested review from
cshnimble,
dneed-nimble,
paullocknimble,
danielryannimble,
nwarms,
elielijah321 and
mshakirdfe
as code owners
cshnimble
suggested changes
Aug 27, 2024
|
|
||
| static path = 'task-list' | ||
| static path1 = 'groups/project-list' |
There was a problem hiding this comment.
Can this have a more descriptive name please?
| urnField: '[data-cy="UKPRN"]', | ||
| continueButton: '[data-cy="submit-btn"]', | ||
| conversionSelection: '[id="available-conversion-\\[0\\]"]', | ||
| confirmandcontinue: '[data-cy="select-common-submitbutton"]' |
There was a problem hiding this comment.
needs to use lower camel case like other variable names for consistency
| } | ||
|
|
||
| static deleteGroup() { | ||
| cy.get('[data-cy="tes"]').click(); |
There was a problem hiding this comment.
I know it's not been added in this PR, but is this data-cy tag named well?
| import { decisionPage } from '../../pages/decisionPage'; | ||
| import { Logger } from '../../support/logger'; | ||
|
|
||
| describe('Decisions Tests', () => { |
There was a problem hiding this comment.
Are these still decisions tests?
| Logger.log("Click on create a group"); | ||
| projectTaskList.clickCreateGroupBtn(); | ||
|
|
||
| Logger.log("enerting which trust will the group join"); |
cshnimble
approved these changes
Aug 28, 2024
mshakirdfe
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automation test creates a conversion, verifies it, tests the new Groups feature, and then deletes the created group.